hummypkg
/
webif
5
3
Fork 4
Code Issues Pull Requests Releases 1 Activity

Change slotid of dummy entry to -1 in checkconfilcts to prevent confusion with real recording slot 0 #49

Merged
prpr merged 1 commits from :fixIncorrectConflicts into master 2023-11-02 11:00:43 +00:00
Conversation 0 Commits 1 Files Changed 1 +13 -9
MymsMan commented 2023-11-01 21:51:24 +00:00
Contributor
Copy Link

See https://hummy.tv/forum/threads/incorrect-conflict-shown.11082/ for full details of the issue.

I currently have two sets of conflicts in my recording schedule, on Wednesday evening and next Friday afternoon
When I attempt to resolve the later conflict by rescheduling Countdown to C4+1 Webif reports a conflict with two of the Wednesday evening conflicting programmes. This also occurs when scheduling any programme using the webif epg

The checkconfilct procedure works by adding a dummy entry to the recording events list and checking whether that causes a conflict,

The dummy entry has recording slot number 0 but my scheduled recording for Signora Volpe has also been assigned to recording slot 0
So when a conflict for slot 0 is returned to checkconflict it erroneously assumes that it is for the dummy entry it created and the warning box is created

The fix to the problem is quite simple, merely changing the slot no in the dummy entry to -1 so that it cant conflict with a real recording

See https://hummy.tv/forum/threads/incorrect-conflict-shown.11082/ for full details of the issue. I currently have two sets of conflicts in my recording schedule, on Wednesday evening and next Friday afternoon When I attempt to resolve the later conflict by rescheduling Countdown to C4+1 Webif reports a conflict with two of the Wednesday evening conflicting programmes. This also occurs when scheduling any programme using the webif epg The checkconfilct procedure works by adding a dummy entry to the recording events list and checking whether that causes a conflict, The dummy entry has recording slot number 0 but my scheduled recording for Signora Volpe has also been assigned to recording slot 0 So when a conflict for slot 0 is returned to checkconflict it erroneously assumes that it is for the dummy entry it created and the warning box is created The fix to the problem is quite simple, merely changing the slot no in the dummy entry to -1 so that it cant conflict with a real recording
MymsMan added 1 commit 2023-11-01 21:51:30 +00:00
prpr merged commit 8e80e86d70 into master 2023-11-02 11:00:43 +00:00
MymsMan deleted branch fixIncorrectConflicts 2023-11-02 11:57:42 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hummypkg/webif#49
No description provided.
Delete Branch ":fixIncorrectConflicts"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?