hummypkg
/
webif
5
3
Fork 4
Code Issues Pull Requests Releases 1 Activity

Improve checks for existing command/proc #29

Closed
df wants to merge 13 commits from df/webif:df-commandcheck-patch into master
pull from: df/webif:df-commandcheck-patch
merge into: hummypkg:master
Conversation 1 Commits 13 Files Changed 12 +23 -23
df commented 2020-12-31 00:00:43 +00:00
Owner
Copy Link

exists -command subsumes exists -proc

The latter test is used several times with the intent to check whether a proc or command of that name exists, rather than some proc that is overriding a synonymous command. The former version would be more correct.

Eg:

  • exists -proc class - currently class is a proc but this may not always be so;
  • exists -proc sqlite3.open - sqlite3.open is a command and not a proc.
`exists -command` subsumes `exists -proc` The latter test is used several times with the intent to check whether a proc or command of that name exists, rather than some proc that is overriding a synonymous command. The former version would be more correct. Eg: * `exists -proc class` - currently `class` is a proc but this may not always be so; * `exists -proc sqlite3.open` - `sqlite3.open` is a command and not a proc.
df added 12 commits 2020-12-31 00:00:45 +00:00
b780b3dda8 exists -proc -> exists -command 
`exists -command` subsumes `exists -proc`

This test is generally checking whether the command exists, rather than some proc that is overriding it.

Currently `class` is a proc but this may not always be so.
397d383051 exists -proc -> exists -command 
`sqlite3.open` is currently a command, so the test for it as a proc fails, presumably not what was intended.
6fc0acf22f exists -proc -> exists -command 
Test was failing for `sqlite3.open`
1c5698388c exists -proc -> exists -command 
Test was failing for `sqlite3.open`.
6ac4216d44 exists -proc -> exists -command 
Test was failing for `sqlite3.open`.
0f678564b8 exists -proc -> exists -command 
Test was failing for `sqlite3.open`.
9779b82bd1 exists -proc -> exists -command 
Test was failing for `sqlite3.open`.
1d008a1bce exists -proc -> exists -command 
Test was failing for `sqlite3.open`.
5f29ab2f4d exists -proc -> exists -command 
Test was failing for `sqlite3.open`, `xconv`.
df added 1 commit 2020-12-31 00:01:37 +00:00
df changed title from df-commandcheck-patch to Improve checks for existing commnd/proc 2020-12-31 00:06:05 +00:00
df changed title from Improve checks for existing commnd/proc to Improve checks for existing command/proc 2020-12-31 00:06:12 +00:00
af123 commented 2021-02-24 12:45:45 +00:00
Owner
Copy Link

Squashed and merged

Squashed and merged
af123 closed this pull request 2021-02-24 12:45:45 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hummypkg/webif#29
No description provided.
Delete Branch "df/webif:df-commandcheck-patch"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?