Schedule all epsiodes of series #11

MymsMan · 2020-06-27T11:35:02Z

MymsMan commented

2020-06-27 11:35:02 +00:00

The humax always tries to schedule all episodes of a series even if you select a later episode when scheduling
The rsv construct method only schedules the selected episode and following episodes, which while different from the Humax could be what is wanted in some circumstances but the method used only works if there is a single episode prior to the one selected,

Several alternative solutions were considered:

Change it do what was intended by adding the earlier episodes to szRecordedProgCrid and the skip table so all earlier episodes are properly skipped.
Match Humax and add all episodes that haven't started to aul eg if {[$i get start] < $now}
Alllow to record currently playing episode eg if {[$i get end] < $now}
Leave aul empty and let humax fill it (like refresh events)
Should refresh events refill aul instead of leaving it empy?
Give users the choice of All, From selected episode
something else ...

While option 1 is attractive the szRecordedProgCrid is limited to 5 episodes so wouldn't work for all series, and the Skip table needs the slot number which hasn't been assigned yet, so to it would be more difficult to implement correctly.

Option 3 is the method implemented in this pull request since it brings seies and single recordings more into sync with ability to record already started programmes and reduces differences from standard humax behaviour,

Option 6 could still be implemented if there were user demand.

Note: The check for 'seen' episode's is moved down so that episodes in the past are not considered to be seen.

The humax always tries to schedule all episodes of a series even if you select a later episode when scheduling The rsv construct method only schedules the selected episode and following episodes, which while different from the Humax could be what is wanted in some circumstances but the method used only works if there is a single episode prior to the one selected, Several alternative solutions were considered: 1. Change it do what was intended by adding the earlier episodes to szRecordedProgCrid and the skip table so all earlier episodes are properly skipped. 1. Match Humax and add all episodes that haven't started to aul eg if {[$i get start] < $now} 1. Alllow to record currently playing episode eg if {[$i get end] < $now} 1. Leave aul empty and let humax fill it (like refresh events) 1. Should refresh events refill aul instead of leaving it empy? 1. Give users the choice of All, From selected episode 1. something else ... While option 1 is attractive the szRecordedProgCrid is limited to 5 episodes so wouldn't work for all series, and the Skip table needs the slot number which hasn't been assigned yet, so to it would be more difficult to implement correctly. Option 3 is the method implemented in this pull request since it brings seies and single recordings more into sync with ability to record already started programmes and reduces differences from standard humax behaviour, Option 6 could still be implemented if there were user demand. Note: The check for 'seen' episode's is moved down so that episodes in the past are not considered to be seen.

af123 approved these changes 2020-10-16 13:15:48 +00:00

af123 referenced this issue from a commit

2020-10-16 13:16:27 +00:00

Merge pull request 'Schedule all epsiodes of series' (#11) from MymsMan/webif:SeriesSched into master Reviewed-on: https://git.hpkg.tv/hummypkg/webif/pulls/11

af123 merged commit 480108f3a2 into master

2020-10-16 13:16:27 +00:00

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hummypkg/webif#11