hummypkg
/
webif
5
3
Fork 4
Code Issues Pull Requests Releases 1 Activity

df-browse-sizesort-patch #9

Merged
af123 merged 5 commits from df/webif:df-browse-sizesort-patch into master 2020-06-17 23:58:34 +00:00
Conversation 3 Commits 5 Files Changed 2 +32 -14
df commented 2020-06-15 03:22:24 +00:00
Owner
Copy Link

Add sort by size asc/desc to media browser display, per https://hummy.tv/forum/threads/webif-web-interface-1-4-x.7712/post-142116.

Sort line is reorganised like this, with x for the icons:

Sort by: x name x date x reverse-date x size (current) x size-reverse

Perhaps rename like this?

Sort by: x name x newest x oldest x smallest (current) x biggest

Or add tooltips to explain what (eg) reverse-size means?

Icon for sort-size uses a disk-space pie.

Add sort by size asc/desc to media browser display, per https://hummy.tv/forum/threads/webif-web-interface-1-4-x.7712/post-142116. Sort line is reorganised like this, with x for the icons: ```plain Sort by: x name x date x reverse-date x size (current) x size-reverse ``` Perhaps rename like this? ```plain Sort by: x name x newest x oldest x smallest (current) x biggest ``` Or add tooltips to explain what (eg) reverse-size means? Icon for sort-size uses a disk-space pie.
af123 commented 2020-06-15 17:23:43 +00:00
Owner
Copy Link

Looks good - I'd be happy with name changes in general. I don't think it's obvious what sort newest means versus oldest, but people will learn which way round it is.
largest rather than biggest I think.

Looks good - I'd be happy with name changes in general. I don't think it's obvious what sort `newest` means versus `oldest`, but people will learn which way round it is. `largest` rather than `biggest` I think.
df commented 2020-06-16 10:22:23 +00:00
Author
Owner
Copy Link

If you don't find the new names obvious I don't think it's worth changing. Instead I've added a tooltip for each sort order, where there's less of a constraint on the length.

The problem with the proposed names was that the word "first" was needed to clarify all except 'name' but that overflowed the space if applied individually, and didn't make sense if applied to all the options.

If you don't find the new names obvious I don't think it's worth changing. Instead I've added a tooltip for each sort order, where there's less of a constraint on the length. The problem with the proposed names was that the word "first" was needed to clarify all except 'name' but that overflowed the space if applied individually, and didn't make sense if applied to all the options.
df changed title from WIP:df-browse-sizesort-patch to df-browse-sizesort-patch 2020-06-16 10:25:03 +00:00
af123 commented 2020-06-17 23:58:27 +00:00
Owner
Copy Link

Thanks - nice use of tailcall for the more generic sort function!

Thanks - nice use of tailcall for the more generic sort function!
af123 closed this pull request 2020-06-17 23:58:34 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hummypkg/webif#9
No description provided.
Delete Branch "df/webif:df-browse-sizesort-patch"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?