hummypkg
/
webif
5
3
Fork 4
Code Issues Pull Requests Releases 1 Activity

Move favicon.ico to prevent errors during install #17

Closed
MymsMan wants to merge 3 commits from (deleted):favicon into master
pull from: (deleted):favicon
merge into: hummypkg:master
Conversation 3 Commits 3 Files Changed 3
MymsMan commented 2020-09-06 17:10:17 +00:00
Contributor
Copy Link

See https://hummy.tv/forum/threads/file_md5sum_alloc-failed-to-open-file-mod-webif-html-favicon-ico-no-such-file-or-directory.9860 for discussion leading up to this change

We have long suffered from `Collected errors:

  • file_md5sum_alloc: Failed to open file /mod/webif/html/favicon.ico: No such file or directory.` error messages during installation of the webif package.

These are due to webif/html/favicon.ico being a symlink rather than the actual icon file.

As far as I can see the only use of /mod/webif/html/img/fav/favicon.ico is as the symlink target, there are no other uses that I could find

So my conclusion is that webif/html/img/fav/favicon.ico should be moved to webif/html/favicon.ico with no symlinks pointing back to it
Also we should delete unreferenced (AFAIK) file webif/html/img/favicon.ico (on my system this contains the orange hpkg icon)
That way we wont have the confusion of multiple favicon.ico files and should solve the file not found problem

See [https://hummy.tv/forum/threads/file_md5sum_alloc-failed-to-open-file-mod-webif-html-favicon-ico-no-such-file-or-directory.9860](https://hummy.tv/forum/threads/file_md5sum_alloc-failed-to-open-file-mod-webif-html-favicon-ico-no-such-file-or-directory.9860) for discussion leading up to this change We have long suffered from `Collected errors: * file_md5sum_alloc: Failed to open file /mod/webif/html/favicon.ico: No such file or directory.` error messages during installation of the webif package. These are due to webif/html/favicon.ico being a symlink rather than the actual icon file. As far as I can see the only use of /mod/webif/html/img/fav/favicon.ico is as the symlink target, there are no other uses that I could find So my conclusion is that webif/html/img/fav/favicon.ico should be moved to webif/html/favicon.ico with no symlinks pointing back to it Also we should delete unreferenced (AFAIK) file webif/html/img/favicon.ico (on my system this contains the orange hpkg icon) That way we wont have the confusion of multiple favicon.ico files and should solve the file not found problem
MymsMan added 1 commit 2020-12-25 22:38:41 +00:00
af123 commented 2021-02-24 14:55:58 +00:00
Owner
Copy Link

I've replaced the symbolic link in the package with a copy of the file - hopefully that will stop the spurious errors while still allowing people to change the file if they wish
(although arguably, EXTRA.css is a better mechanism for overriding the favicon these days)

I've replaced the symbolic link in the package with a copy of the file - hopefully that will stop the spurious errors while still allowing people to change the file if they wish (although arguably, EXTRA.css is a better mechanism for overriding the favicon these days)
af123 closed this pull request 2021-02-24 14:56:01 +00:00
prpr commented 2021-02-24 17:03:35 +00:00
Owner
Copy Link

I hate the blue ring on a black background and much prefer the orange/h (which I still get on my tabs on FF) as it's much easier to see.
Could you write some brief instructions on the extra.css thing?

I hate the blue ring on a black background and much prefer the orange/h (which I still get on my tabs on FF) as it's much easier to see. Could you write some brief instructions on the extra.css thing?
af123 commented 2021-02-24 18:32:11 +00:00
Owner
Copy Link

I hate the blue ring on a black background and much prefer the orange/h (which I still get on my tabs on FF) as it's much easier to see.
Could you write some brief instructions on the extra.css thing?

I was wrong, it isn't possible to specify the favicon in a css file.
With the new webif beta and beyond, your best approach is to do this which will drop the orange h into place over the default, and because html/favicon.ico is in CONTROL/conffiles, it will be preserved over future upgrades.

cd /mod/webif/html
cp img/favicon.ico .
> I hate the blue ring on a black background and much prefer the orange/h (which I still get on my tabs on FF) as it's much easier to see. > Could you write some brief instructions on the extra.css thing? > I was wrong, it isn't possible to specify the favicon in a css file. With the new webif beta and beyond, your best approach is to do this which will drop the orange h into place over the default, and because html/favicon.ico is in CONTROL/conffiles, it will be preserved over future upgrades. ``` cd /mod/webif/html cp img/favicon.ico . ```

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hummypkg/webif#17
No description provided.
Delete Branch "(deleted):favicon"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?